Fix Windows Media Element in MultiWindow Mode on exit Crash #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a static `NumberOfWindows` property to the `Options` class to track the number of windows. Updated `SetShouldEnableSnackbarOnWindows` to increment/decrement `NumberOfWindows` on window creation/closure. Conditional registration/unregistration of `AppNotificationManager` for snackbar notifications based on `NumberOfWindows` count.
McSaverInvestments
approved these changes
Oct 26, 2024
McSaverInvestments
left a comment
McSaverInvestments
left a comment
There was a problem hiding this comment.
This changed fixed #2279
Hoping it will be released soon
24 tasks
pictos
reviewed
Nov 11, 2024
|
Can some please resolve this merge conflict? |
|
I am new to this process, and don't understand who needs to do what to get this done, but I would appreciate any help to get the mission accomplished. @brminnick @ne0rrmatrix @pictos @softlion |
pictos
approved these changes
Feb 4, 2025
Member
|
@ne0rrmatrix what's holding this PR to be merged? |
Member
Author
|
Nothing that I can think of. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Track window count and manage snackbar notifications
Added a static
NumberOfWindowsproperty to theOptionsclass to track the number of windows. UpdatedSetShouldEnableSnackbarOnWindowsto increment/decrementNumberOfWindowson window creation/closure. Conditional registration/unregistration ofAppNotificationManagerfor snackbar notifications based onNumberOfWindowscount.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
This PR uses a simple counter to track the number of windows that exist and only when one is remaining will it unregister Snackview